Change in vdsm[master]: using rpm in rhevh and ovirt as well

danken at redhat.com danken at redhat.com
Tue Jul 21 11:26:15 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: using rpm in rhevh and ovirt as well
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

the commit message must be improved, and Fabian must approve.

https://gerrit.ovirt.org/#/c/42877/1/vdsm/caps.py
File vdsm/caps.py:

Line 555:                 release_path = '/etc/ibm_powerkvm-release'
Line 556:             elif osname == OSName.RHEVH:
Line 557:                 release_path = '/etc/rhev-hypervisor-release'
Line 558:             elif osname == OSName.OVIRT:
Line 559:                 release_path = '/etc/fedora-release'
this should be an ovirt-node release file, not a Fedora one.
Line 560:             else:
Line 561:                 release_path = '/etc/redhat-release'
Line 562: 
Line 563:             ts = rpm.TransactionSet()


-- 
To view, visit https://gerrit.ovirt.org/42877
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84352b23bfad0239f79944d036f8484506fdfcc9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list