Change in vdsm[master]: net: test_setupNetworks_bond_with_custom_option with ifcfg p...

danken at redhat.com danken at redhat.com
Mon Jul 20 14:13:29 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: test_setupNetworks_bond_with_custom_option with ifcfg persistence
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/43467/4/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2624:         with dummyIf(2) as nics:
Line 2625:             status, msg = self.setupNetworks(
Line 2626:                 {},
Line 2627:                 {BONDING_NAME: {'nics': nics,
Line 2628:                                 'options': 'custom=foo mode=802.3ad'}},
I find that this patch fixes the wrong bug: with unified persistence, we should persist custom=foo. Let's solve this issue first.
Line 2629:                 NOCHK, test_kernel_config=False)
Line 2630:             self.assertEqual(status, SUCCESS, msg)
Line 2631:             self.assertBondExists(BONDING_NAME, nics)
Line 2632:             if vdsm.config.config.get('vars', 'net_persistence') == 'unified':


Line 2628:                                 'options': 'custom=foo mode=802.3ad'}},
Line 2629:                 NOCHK, test_kernel_config=False)
Line 2630:             self.assertEqual(status, SUCCESS, msg)
Line 2631:             self.assertBondExists(BONDING_NAME, nics)
Line 2632:             if vdsm.config.config.get('vars', 'net_persistence') == 'unified':
again: let's not test Vdsm's implementation here. Functional tests should test the API, and if Vdsm reports the correct values, we should be happy.
Line 2633:                 opts = self.vdsm_net.config.bonds.get(
Line 2634:                     BONDING_NAME).get('options')
Line 2635:                 self.assertEquals(opts, 'mode=802.3ad')
Line 2636:             else:  # ifcfg persistence


-- 
To view, visit https://gerrit.ovirt.org/43467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I178383e2c0125a1a661108ca9bbb28da74b1a11a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list