Change in vdsm[master]: scheduler: use single instance
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Mon Jul 20 11:51:52 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: scheduler: use single instance
......................................................................
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/43825/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 95: self.mom = None
Line 96: self.bindings = {}
Line 97: self._broker_client = None
Line 98: self._subscriptions = defaultdict(list)
Line 99: self._scheduler = schedule.Scheduler(name="periodic.Scheduler",
> This is not "periodic.Scheduler" now, but just "scheduler".
Done
Line 100: clock=utils.monotonic_time)
Line 101: if _glusterEnabled:
Line 102: self.gluster = gapi.GlusterApi(self, log)
Line 103: else:
Line 96: self.bindings = {}
Line 97: self._broker_client = None
Line 98: self._subscriptions = defaultdict(list)
Line 99: self._scheduler = schedule.Scheduler(name="periodic.Scheduler",
Line 100: clock=utils.monotonic_time)
> We want to kill clientIF, not add more state to it.
Done
Line 101: if _glusterEnabled:
Line 102: self.gluster = gapi.GlusterApi(self, log)
Line 103: else:
Line 104: self.gluster = None
Line 286: self._enabled = False
Line 287: secret.clear()
Line 288: self.channelListener.stop()
Line 289: self._hostStats.stop()
Line 290: self._scheduler.stop()
> Better stop this in vdsm, where we should create and start it.
Done
Line 291: if self.irs:
Line 292: return self.irs.prepareForShutdown()
Line 293: else:
Line 294: return {'status': doneCode}
https://gerrit.ovirt.org/#/c/43825/1/vdsm/vdsm
File vdsm/vdsm:
Line 94:
Line 95: install_manhole({'irs': irs, 'cif': cif})
Line 96:
Line 97: cif.start()
Line 98: runner = periodic.PeriodicOperationRunner()
> Unneeded
Done
Line 99: runner.start(cif)
Line 100: try:
Line 101: while running[0]:
Line 102: sigutils.wait_for_signal()
https://gerrit.ovirt.org/#/c/43825/1/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
> I don't think these changes are needed. We need exactly one periodic execut
Done
Line 1: #
Line 2: # Copyright 2015 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
--
To view, visit https://gerrit.ovirt.org/43825
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If83eded458f8304d802fcd75839e7a916146918b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list