Change in vdsm[master]: arbitrary_vlan_name: Fix network deletion

danken at redhat.com danken at redhat.com
Mon Jul 20 11:37:02 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: arbitrary_vlan_name: Fix network deletion
......................................................................


arbitrary_vlan_name: Fix network deletion

Up until now, when the network deletion operations were not being
forced, the assertion that the bridge was clean, i.e., that it did
not have other ports (vnics most likely) would fail because it
expected

    bondname.vlanid
or
    nic.vlanid

when the name could be any string. This patch addresses the issue
by making netinfo give us the exact vlan name.

Change-Id: I715806db38ce621098fe5f364e16e874a5ed01ed
Bug-Url: http://bugzilla.redhat.com/1119182
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/30013
Tested-by: Ido Barkan <ibarkan at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netconfpersistence.py
M lib/vdsm/netinfo.py
M vdsm/API.py
M vdsm/network/api.py
M vdsm/network/models.py
5 files changed, 32 insertions(+), 20 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/30013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I715806db38ce621098fe5f364e16e874a5ed01ed
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list