Change in vdsm[master]: netinfo: Drop ifcfg reading from _getNetInfo

danken at redhat.com danken at redhat.com
Mon Jul 20 10:34:09 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Drop ifcfg reading from _getNetInfo
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/35012/3/vdsm/network/api.py
File vdsm/network/api.py:

Line 877:                 _delNetwork(network, configurator=configurator, force=force,
Line 878:                             implicitBonding=False, _netinfo=_netinfo,
Line 879:                             keep_bridge=keep_bridge)
Line 880:                 del _netinfo.networks[network]
Line 881:                 _netinfo.updateDevices()
Why is this required?
Line 882:             elif network in libvirt_nets:
Line 883:                 # If the network was not in _netinfo but is in the networks
Line 884:                 # returned by libvirt, it means that we are dealing with
Line 885:                 # a broken network.


-- 
To view, visit https://gerrit.ovirt.org/35012
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a80251cc45792ba5511d22bce9451fb3b36689d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list