Change in vdsm[master]: hostdev: add test for SR-IOV guest addressing

ibarkan at redhat.com ibarkan at redhat.com
Mon Jul 20 10:15:01 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: hostdev: add test for SR-IOV guest addressing
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/43095/2/tests/hostdevTests.py
File tests/hostdevTests.py:

Line 426:                      'function': '0x0', 'type': 'pci'}}
Line 427:         device = hostdevice.HostDevice(self.conf, self.log, **dev_spec)
Line 428:         self.assertXMLEqual(
Line 429:             device.getXML().toxml(),
Line 430:             _DEVICE_XML[_SRIOV_VF] %
nit: I would simply unify this test with testCreateSRIOVVF and avoid the ugly string formatting. Also, in most business cases engine does supply the address. so this  test is a superset of testCreateSRIOVVF, which makes the latter redundant.
but other than that, the test gets things done.
Line 431:             ('<address bus="0x01" domain="0x0000" function="0x0" slot="0x02" \


-- 
To view, visit https://gerrit.ovirt.org/43095
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c204101290294d5b8b9819b9acca871a9976322
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list