Change in vdsm[master]: net: remove redundant validation during network deletion

yzaspits at redhat.com yzaspits at redhat.com
Sun Jul 19 16:08:32 UTC 2015


Yevgeny Zaspitsky has posted comments on this change.

Change subject: net: remove redundant validation during network deletion
......................................................................


Patch Set 3: Verified-1

Vdsm doesn't allow adding vlan tagging to the network that is used by VMs.

Traceback (most recent call last):
  File "/usr/share/vdsm/supervdsmServer", line 110, in wrapper
    res = func(*args, **kwargs)
  File "/usr/share/vdsm/supervdsmServer", line 217, in setupNetworks
    return setupNetworks(networks, bondings, **options)
  File "/usr/share/vdsm/network/api.py", line 881, in setupNetworks
    keep_bridge=keep_bridge)
  File "/usr/share/vdsm/network/api.py", line 215, in wrapped
    ret = func(**attrs)
  File "/usr/share/vdsm/network/api.py", line 457, in _delNetwork
    bridged and not keep_bridge, _netinfo)
  File "/usr/share/vdsm/network/api.py", line 410, in _validateDelNetwork
    assertBridgeClean(network, vlan, bonding, nics)
  File "/usr/share/vdsm/network/api.py", line 343, in assertBridgeClean
    ' %s connected' % (bridge, brifs))
ConfigNetworkError: (28, u"bridge mgm has interfaces set([u'vnet1', u'vnet2']) connected")

-- 
To view, visit https://gerrit.ovirt.org/43710
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I806410e5d2ee2a4794e3547f52ef43804d010d1c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list