Change in vdsm[master]: StorageDomainManifest: introduce produceVolumeMetadata
nsoffer at redhat.com
nsoffer at redhat.com
Sat Jul 18 16:06:30 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: introduce produceVolumeMetadata
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43552/3/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line 189: """
Line 190: return fileVolume.FileVolume
Line 191:
Line 192: def getVolumeMetadataClass(self):
Line 193: return fileVolume.FileVolumeMetadata
Why not a class attribute?
volumeMetadataClass = fileVolume.FileVolumeMetadata
Then in sd.py:
return volumeMetadataClass(...)
Line 194:
Line 195: def deleteImage(self, sdUUID, imgUUID, volsImgs):
Line 196: currImgDir = self.getImagePath(imgUUID)
Line 197: dirName, baseName = os.path.split(currImgDir)
--
To view, visit https://gerrit.ovirt.org/43552
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f4222fefd06abb1ed1919371598ec0b94e5492d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list