Change in vdsm[master]: vm: events: do not send hashes in status messages

danken at redhat.com danken at redhat.com
Fri Jul 17 22:33:49 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: vm: events: do not send hashes in status messages
......................................................................


Patch Set 13: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/43386/13//COMMIT_MSG
Commit Message:

Line 4: Commit:     Francesco Romani <fromani at redhat.com>
Line 5: CommitDate: 2015-07-17 17:45:04 +0200
Line 6: 
Line 7: vm: events: do not send hashes in status messages
Line 8: 
the important thing here is that the hashes were a poor man's event mechanism, which is not needed when we can provide the whole information within an event.
Line 9: Engine doesn't really benefit of hashes in each VM_status
Line 10: message. We should send it only whenever matters,
Line 11: like when VM goes PoweringUp/Up.
Line 12: 


-- 
To view, visit https://gerrit.ovirt.org/43386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f4bc76947df86a978820e6eb8d5758532e14b3
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list