Change in vdsm[master]: vmstats: fine-grained KeyError handling

fromani at redhat.com fromani at redhat.com
Fri Jul 17 15:21:55 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vmstats: fine-grained KeyError handling
......................................................................


Patch Set 3: Verified+1

before this patch:

Traceback (most recent call last):
  File "/usr/share/vdsm/virt/vmstats.py", line 267, in disks
    interval))
  File "/usr/share/vdsm/virt/vmstats.py", line 297, in _disk_rate
    (last_sample['block.%d.rd.bytes' % last_index] -
KeyError: 'block.3.rd.bytes'


please note that the actual key which triggers the KeyError may be random.
After this patch: no more noise in the logs.

-- 
To view, visit https://gerrit.ovirt.org/43777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04ecbf98d36d576ede3c3cde36586245ea5e4218
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list