Change in vdsm[master]: network: wait for a bridge to appear before disabling IPv6 o...
danken at redhat.com
danken at redhat.com
Fri Jul 17 12:43:09 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: network: wait for a bridge to appear before disabling IPv6 on it
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43583/1/vdsm/network/configurators/__init__.py
File vdsm/network/configurators/__init__.py:
Line 180: raise ConfigNetworkError(ERR_FAILED_IFUP, 'dhclient%s failed',
Line 181: family)
Line 182:
Line 183:
Line 184: def wait_for_bridge(name, timeout=1):
> I get the point that as well as a bridge may be added too late, any virtual
I don't think we need to make the signature of this function more complex, but it would be nicer to make it more generic by replacing
netinfo.bridges() --> vdsm.ipwrapper.getLinks()
and renaming the function as requested.
Line 185: """
Line 186: Wait for a bridge to appear in a given timeout. If the bridge is not
Line 187: created by then, raise a ConfigNetworkError.
Line 188: """
--
To view, visit https://gerrit.ovirt.org/43583
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5292e5a297ff50a0e82ba0781333e21fd9dd7f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list