Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (disk)

danken at redhat.com danken at redhat.com
Fri Jul 17 11:13:37 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: vmstats: fix bulk stats misinterpretation (disk)
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/43682/4/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 221:             if isVdsmImage(vm_drive):
Line 222:                 drive_stats['imageID'] = vm_drive.imageID
Line 223:             elif "GUID" in vm_drive:
Line 224:                 drive_stats['lunGUID'] = vm_drive.GUID
Line 225: 
if you keep this linear function inside the linear for, and a big FIXME.
Line 226:             first_index = _find_bulk_stat_index(
Line 227:                 first_sample, 'block', vm_drive.name)
Line 228:             last_index = _find_bulk_stat_index(
Line 229:                 last_sample, 'block', vm_drive.name)


-- 
To view, visit https://gerrit.ovirt.org/43682
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d03dc914a4a9f729519ebd1365754e63833d300
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list