Change in vdsm[master]: vmstats: rename 'nic' function

danken at redhat.com danken at redhat.com
Fri Jul 17 10:53:55 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vmstats: rename 'nic' function
......................................................................


vmstats: rename 'nic' function

The vmstats module exports a 'nic' function, which
produces the stats per-nic, in the format Engine expects.

The problem here is that 'nic' is a too nice name, so there
are other legitimate uses for it in other flows.

To reduce the possibility of name clash, we just rename
the function to the little less nice but little more revealing
'nic_traffic'.

This is also a little lie because 'nic_traffic' adds fields
which aren't strictly related to traffic proper. Future patch
will clean this further and remove the little lie.

Rename only.

Change-Id: I4b9290843c9dc7adc9709a66a0bb97238437bd37
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/43694
Continuous-Integration: Jenkins CI
Reviewed-by: Marcin Mirecki <mmirecki at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmTests.py
M vdsm/virt/vmstats.py
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Marcin Mirecki: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/43694
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b9290843c9dc7adc9709a66a0bb97238437bd37
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list