Change in vdsm[master]: network: wait for a bridge to appear before disabling IPv6 o...

danken at redhat.com danken at redhat.com
Thu Jul 16 13:17:01 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: network: wait for a bridge to appear before disabling IPv6 on it
......................................................................


Patch Set 1:

(1 comment)

Pavel Zhukov says that https://bugzilla.redhat.com/show_bug.cgi?id=1240921 was openend regarding something else.

https://gerrit.ovirt.org/#/c/43583/1/vdsm/network/configurators/__init__.py
File vdsm/network/configurators/__init__.py:

Line 187:     created by then, raise a ConfigNetworkError.
Line 188:     """
Line 189:     with monitor.Monitor(timeout=timeout, groups=('link',),
Line 190:                          silent_timeout=True) as mon:
Line 191:         if name in netinfo.bridges():
> Can you short-circuit before creating the monitor? Or it is a potential rac
yes, checking (name in netinfo.bridges()) before listening to the monitor opens a race. We may miss the event about the new device, and wait in "for event in mon" forever.
Line 192:             return
Line 193:         for event in mon:
Line 194:             if event.get('name') == name and event.get('event') == 'new_link':
Line 195:                 return


-- 
To view, visit https://gerrit.ovirt.org/43583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5292e5a297ff50a0e82ba0781333e21fd9dd7f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list