Change in vdsm[master]: sp: Move spm validation methods to StoragePool

nsoffer at redhat.com nsoffer at redhat.com
Thu Jul 16 13:01:04 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: sp: Move spm validation methods to StoragePool
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/43542/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 548:         if domVersion is not None:
Line 549:             domVersion = int(domVersion)
Line 550:             sd.validateDomainVersion(domVersion)
Line 551: 
Line 552:         # This code is repeated twice for performance reasons
> ok
This is handled in the next patch, I don't want to mix unrelated changes.
Line 553:         # Avoid waiting for the lock for validate.
Line 554:         self.getPool(spUUID).validateNotSPM()
Line 555: 
Line 556:         vars.task.getExclusiveLock(STORAGE, spUUID)


-- 
To view, visit https://gerrit.ovirt.org/43542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115896cc67634741d7227fc00d8b294b3fe48ac6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list