Change in vdsm[master]: vmstats: avoid explicit string conversion

fromani at redhat.com fromani at redhat.com
Thu Jul 16 10:54:35 UTC 2015


Francesco Romani has uploaded a new change for review.

Change subject: vmstats: avoid explicit string conversion
......................................................................

vmstats: avoid explicit string conversion

Now that we streamlined the reporting of disk stats,
we can get rid of explicit conversion loop and simplify
the code.

Change-Id: I99c0353828f3690411faf25edda40e6ddac8641e
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vmstats.py
1 file changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/43718/1

diff --git a/vdsm/virt/vmstats.py b/vdsm/virt/vmstats.py
index 891c137..17f44fb 100644
--- a/vdsm/virt/vmstats.py
+++ b/vdsm/virt/vmstats.py
@@ -65,16 +65,6 @@
             value = vm_stats[var]
             if value:
                 stats[var] = value
-        else:
-            if 'disks' not in stats:
-                stats['disks'] = {}
-            try:
-                stats['disks'][var] = {}
-                for value in vm_stats[var]:
-                    stats['disks'][var][value] = \
-                        convertToStr(vm_stats[var][value])
-            except Exception:
-                logging.exception("Error setting vm disk stats")
 
     return stats
 


-- 
To view, visit https://gerrit.ovirt.org/43718
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99c0353828f3690411faf25edda40e6ddac8641e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list