Change in vdsm[master]: vdsm hooks: report hook stderr to Engine if it fails an action

fromani at redhat.com fromani at redhat.com
Thu Jul 16 09:11:39 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vdsm hooks: report hook stderr to Engine if it fails an action
......................................................................


Patch Set 20: Code-Review+1

(2 comments)

looks ok, minor comments inside

https://gerrit.ovirt.org/#/c/42592/20/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 306:         except MigrationDestinationSetupError as e:
Line 307:             self._recover(str(e))
Line 308:             # we know what happened, no need to dump hollow stack trace
Line 309:         except hooks.HookError as e:
Line 310:             self.status = response.error('hookError', 'Hook error: ' + str(e))
perhaps prepending the error message with 'Hook error: ' is redundant when error code is hookError.
Line 311:             self._recover(str(e))
Line 312:         except Exception as e:
Line 313:             self._recover(str(e))
Line 314:             self.log.exception("Failed to migrate")


Line 340: 
Line 341:             if response.is_error(result):
Line 342:                 self.status = result
Line 343:                 hookErrorCode = errCode['hookError']['status']['code']
Line 344:                 if result['status']['code'] == hookErrorCode:
for a future patch, we'll figure out a more expressive way to do this, perhaps extending the response module
Line 345:                     raise hooks.HookError(result['status']['message'])
Line 346:                 raise MigrationDestinationSetupError(
Line 347:                     'migration destination error: ' +
Line 348:                     result['status']['message'])


-- 
To view, visit https://gerrit.ovirt.org/42592
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d5eb52cf2c8855d9d7d5e0ff1628a6cf1dc51
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Feng Yang <yangfeng at cloud-times.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list