Change in vdsm[master]: tests: Create storagetestutils module

nsoffer at redhat.com nsoffer at redhat.com
Wed Jul 15 19:53:33 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tests: Create storagetestutils module
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/43547/2/tests/storagetestlib.py
File tests/storagetestlib.py:

Line 63:     return vg_name
Line 64: 
Line 65: 
Line 66: def get_metafile_path(domaindir):
Line 67:     return os.path.join(domaindir, sd.DOMAIN_META_DATA, sd.METADATA)
> It's not trivial enough to be worth it.  The proper path is built up after 
ok
Line 68: 
Line 69: 
Line 70: def make_filesd_manifest(tmpdir, metadata=None):
Line 71:     sduuid = str(uuid.uuid4())


-- 
To view, visit https://gerrit.ovirt.org/43547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I713e19473b45bc05da5a1c888a034306144228c5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list