Change in vdsm[master]: virt: removing naming confilct in vmstats.py

fromani at redhat.com fromani at redhat.com
Wed Jul 15 19:32:08 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: removing naming confilct in vmstats.py
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/43657/1/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 184:         last_nic = last_sample.get('net', {}).get(vm_nic.name, {})
Line 185:         # may happen if nic is a new hot-plugged one
Line 186:         if not first_nic or not last_nic:
Line 187:             continue
Line 188:         stats['network'][vm_nic.name] = nic(
in another patch, I will rename nic() as well.
Line 189:             vm_nic.name, vm_nic.nicModel, vm_nic.macAddr,
Line 190:             first_nic, last_nic, interval)
Line 191: 
Line 192: 


-- 
To view, visit https://gerrit.ovirt.org/43657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77307af135e0f6c3d8c5554e0f3fb4093e36ed0d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list