Change in vdsm[master]: spmprotect: Switch from fencing by pid to fencing using syst...

nsoffer at redhat.com nsoffer at redhat.com
Wed Jul 15 15:48:48 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: spmprotect: Switch from fencing by pid to fencing using systemctl
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/43211/7/vdsm/storage/protect/spmprotect.sh.in
File vdsm/storage/protect/spmprotect.sh.in:

Line 73:     (sleep 20 && echodo $REBOOTCMD) &
Line 74:     disown
Line 75:     (sleep 7
Line 76:         log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE"
Line 77:         echodo $SYSTEMCTL kill --signal=TERM vdsmd.service
Does kill and systemctl kill fail in the same way?

For example, if systemctl kill may fail because connection to systemd daemon is broken, or systemd daemon is too busy or something, the operation may fail or take too much time, breaking the fencing logic.

When running kill, we just need to do a syscall, it is less likely to fail.
Line 78:         sleep 2
Line 79:         echodo $SYSTEMCTL kill --signal=KILL vdsmd.service
Line 80:     )&
Line 81:     disown


-- 
To view, visit https://gerrit.ovirt.org/43211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list