Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (disk)
fromani at redhat.com
fromani at redhat.com
Wed Jul 15 15:18:26 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: vmstats: fix bulk stats misinterpretation (disk)
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43682/2/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:
Line 270: def _disk_latency(first_sample, first_index, last_sample, last_index):
Line 271: def compute_latency(ltype):
Line 272: operations = (
Line 273: last_sample['block.%d.%s.ops' % (last_index, ltype)] -
Line 274: first_sample['block.%d.%s.ops' % (first_index, ltype)]
s/ops/reqs/
Line 275: )
Line 276: if not operations:
Line 277: return 0
Line 278: elapsed_time = (
--
To view, visit https://gerrit.ovirt.org/43682
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d03dc914a4a9f729519ebd1365754e63833d300
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list