Change in vdsm[master]: vmstats: fix bulk stats misinterpretation (net)

fromani at redhat.com fromani at redhat.com
Wed Jul 15 14:51:18 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vmstats: fix bulk stats misinterpretation (net)
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/43679/3//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: The current vmstats code is assuming that the bulk stats samples
Line 10: are in a different format than they really are.
Line 11: This mistake dates back to the lastest iterations of bulk stats
Line 12: development, when various approaches to fecth and store bulk stats
> fetch
Done
Line 13: samples were experimented, while looking for good performances.
Line 14: 
Line 15: In the end, we settled for the simplest approach, for the sake of
Line 16: performance. Somehow, the translation patch was lost, most likely in


-- 
To view, visit https://gerrit.ovirt.org/43679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57faae821394576aabc06dfaca2e1b4828a1339b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list