Change in vdsm[master]: virt: total rx/tx stats not send to engine

fromani at redhat.com fromani at redhat.com
Wed Jul 15 14:50:28 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: total rx/tx stats not send to engine
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

thanks for fixing this embarassing mistake of mine.
The problem here is the unneeded of the translation of samples, which I'd like to avoid, bacause seems wasteful and pointless. Instead I'd just construct and use the right keys, like I did in https://gerrit.ovirt.org/#/c/43679/ to fix this and the disk misinterpretation.

So, I think it is easier if you just abandon this and review 43679.

https://gerrit.ovirt.org/#/c/43672/1/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 189:             vm_nic.name, vm_nic.nicModel, vm_nic.macAddr,
Line 190:             first_nic, last_nic, interval)
Line 191: 
Line 192: 
Line 193: def nic_sample(stats, vm_nic_name):
no need to translate the samples. We should use direcly the right keys instead, like this:

https://gerrit.ovirt.org/#/c/43679/
Line 194:     sample = {}
Line 195:     ifc_count = -1
Line 196:     while True:
Line 197:         ifc_count += 1


-- 
To view, visit https://gerrit.ovirt.org/43672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I702a80f19553372e01ba022afaa07d766258062f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list