Change in vdsm[master]: vm: events: do NOT send 'Down' event after destroy

fromani at redhat.com fromani at redhat.com
Wed Jul 15 11:53:10 UTC 2015


Francesco Romani has uploaded a new change for review.

Change subject: vm: events: do NOT send 'Down' event after destroy
......................................................................

vm: events: do NOT send 'Down' event after destroy

Engine doesn't want to receive 'Down' vm_status after
a succesfull 'destroy', and it is actually confused
by status.

So, add an exception on our flow and skip notification.

Change-Id: Ia67abcf7af4d81451e47eb39bff2bbd8baccfbfa
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/43668/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 78b077e..284e63f 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1287,7 +1287,8 @@
         except Exception:
             pass
         self.saveState()
-        if event_data:
+        if not self._destroyed and event_data:
+            # Engine is confused if it receives Down event after a destroy.
             self.send_status_event(**event_data)
 
     def status(self, fullStatus=True):


-- 
To view, visit https://gerrit.ovirt.org/43668
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia67abcf7af4d81451e47eb39bff2bbd8baccfbfa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list