Change in vdsm[master]: sdm: introduce the new createVolumeContainer command

nsoffer at redhat.com nsoffer at redhat.com
Tue Jul 14 23:29:06 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: sdm: introduce the new createVolumeContainer command
......................................................................


Patch Set 17: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/38097/17/vdsm/storage/sdm.py
File vdsm/storage/sdm.py:

Line 38: 
Line 39: 
Line 40: def get_domain_host_id(sdUUID):
Line 41:     # FIXME: irs._obj is an ugly hack, domainMonitor needs internal locking
Line 42:     return cif.getInstance().irs._obj.domainMonitor.getHostId(sdUUID)
This is indeed ugly. The host id should be a property of a domain manifest. You should not access the domain monitor for this.
Line 43: 
Line 44: 
Line 45: def create_volume_container(dom_manifest, img_id, size, vol_format, disk_type,
Line 46:                           vol_id, desc, src_img_id, src_vol_id):


-- 
To view, visit https://gerrit.ovirt.org/38097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3ea624f81a04a830cdcbcfe2f777cdd7bd26c08
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list