Change in vdsm[master]: resourceManager: Avoid unneeded recursive locking

nsoffer at redhat.com nsoffer at redhat.com
Tue Jul 14 19:33:50 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: resourceManager: Avoid unneeded recursive locking
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/43424/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-07-10 21:02:24 +0300
Line 4: Commit:     Nir Soffer <nsoffer at redhat.com>
Line 5: CommitDate: 2015-07-11 01:44:47 +0300
Line 6: 
Line 7: resourceManager: Avoid uneeded recursive locking
> typo: unneeded
Done
Line 8: 
Line 9: In registerNamesapce, when force registering an existing namespace, we
Line 10: first try to remove the existing one using unregisterNamespace. Since
Line 11: both public methods acquire an exclusive lock, we must use a recursive


Line 5: CommitDate: 2015-07-11 01:44:47 +0300
Line 6: 
Line 7: resourceManager: Avoid uneeded recursive locking
Line 8: 
Line 9: In registerNamesapce, when force registering an existing namespace, we
> typo: registerNamespace
Done
Line 10: first try to remove the existing one using unregisterNamespace. Since
Line 11: both public methods acquire an exclusive lock, we must use a recursive
Line 12: lock to avoid deadlock.
Line 13: 


-- 
To view, visit https://gerrit.ovirt.org/43424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6658645bba178fa5f3821a56e3453f62d0c9db4f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list