Change in vdsm[master]: StorageDomainManifest: move extend and extendVolume

nsoffer at redhat.com nsoffer at redhat.com
Tue Jul 14 15:57:26 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: StorageDomainManifest: move extend and extendVolume
......................................................................


Patch Set 12:

(3 comments)

https://gerrit.ovirt.org/#/c/42266/12/tests/storagefakelib.py
File tests/storagefakelib.py:

Line 134:         lv_md['attr'] = lv_attr
Line 135:         return real_lvm.LV(**lv_md)
Line 136: 
Line 137:     def getFirstExt(self, vg, lv):
Line 138:         return self.getLV(vg, lv).devices.strip(" )").split("(")
Does this work?
Line 139: 
Line 140:     def listPVNames(self, vgName):
Line 141:         return self.getVG(vgName).pv_name
Line 142: 


Line 150:         pe_start = 0
Line 151:         for pv in self.pvmd.values():
Line 152:             if pv['pe_start'] > pe_start:
Line 153:                 pe_start = pv['pe_start'] + pv['pe_count']
Line 154:         return pe_start
Of by one error? Should be find_last_pe, and pe_start can be last_pe + 1
Line 155: 
Line 156:     def _create_pv(self, pv_name, vg_name, size):
Line 157:         pe_start = self._find_pe_start(vg_name)
Line 158:         pe_count = (size - self._PV_PE_START) / self._PV_PE_SIZE


https://gerrit.ovirt.org/#/c/42266/12/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 741
Line 742
Line 743
Line 744
Line 745
We move also resizePV using the same _extendLock.


-- 
To view, visit https://gerrit.ovirt.org/42266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ad1769d7e4db6fc0883b37a67d071c278b96c8b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list