Change in vdsm[master]: tests: StompAdapter test suite
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Tue Jul 14 13:45:57 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: tests: StompAdapter test suite
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/43342/3/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 189: else:
Line 190: subs = self._sub_dests[destination]
Line 191: if len(subs) == 0:
Line 192: self._send_error("Subscription not available",
Line 193: dispatcher.connection)
> you still can get KeyError :/ why is it related to the tests?
The KeyError is not raised here because we use defaultdict.
Line 194: return
Line 195:
Line 196: for subscription in subs:
Line 197: headers = utils.picklecopy(frame.headers)
--
To view, visit https://gerrit.ovirt.org/43342
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic22a8ec43413431ff57ecf66da62e065c534bac7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list