Change in vdsm[master]: validate listen_tls config value in libvirtd.conf

danken at redhat.com danken at redhat.com
Tue Jul 14 08:30:08 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: validate listen_tls config value in libvirtd.conf
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/43437/1/lib/vdsm/tool/configurators/libvirt.py
File lib/vdsm/tool/configurators/libvirt.py:

Line 145:                 "FAILED: "
Line 146:                 "conflicting vdsm and libvirt-qemu tls configuration.\n"
Line 147:                 "vdsm.conf with ssl=True "
Line 148:                 "requires the following changes:\n"
Line 149:                 "libvirtd.conf: listen_tcp=0, auth_tcp=\"sasl\", \n"
> maybe worth updating the message?
yes.
Line 150:                 "qemu.conf: spice_tls=1.\n"
Line 151:             )
Line 152:             ret = False
Line 153:     else:


-- 
To view, visit https://gerrit.ovirt.org/43437
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedad148fd0f99fe02988a87a8bdfc0a9cc64d282
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list