Change in vdsm[master]: virt: migration: create full status in migration.py

mmirecki at redhat.com mmirecki at redhat.com
Tue Jul 14 08:01:32 UTC 2015


Marcin Mirecki has posted comments on this change.

Change subject: virt: migration: create full status in migration.py
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/43357/1/vdsm/API.py
File vdsm/API.py:

Line 353:         try:
Line 354:             v = self._cif.vmContainer[self._UUID]
Line 355:         except KeyError:
Line 356:             return errCode['noVM']
Line 357:         return v.migrateStatus()
> ok, but IIRC hooks run either before or after this API.
As I see it, the status of the reply represents not the status of the single API call, but the status of the underlying migration. Therefore even if the single API is successful, the status o the reply can be non-zero to indicate migration failure.
Am I right with this? Is the status:
- the status of the migration, or
- the status of the single API call?
In the second case, an additional field with migration status will need to be send to the engine, and changes to the engine code to handle this will be needed.
Line 358: 
Line 359:     def getStats(self):
Line 360:         """
Line 361:         Obtain statistics of the specified VM


-- 
To view, visit https://gerrit.ovirt.org/43357
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc1525f52dc5ee49647aa6d690f221f2dc96e5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list