Change in vdsm[master]: concurrent: Add Barrier class

fromani at redhat.com fromani at redhat.com
Tue Jul 14 06:31:42 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: concurrent: Add Barrier class
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/42927/6/tests/concurrentTests.py
File tests/concurrentTests.py:

Line 80:         finally:
Line 81:             t.join()
Line 82: 
Line 83:     @permutations([[2], [4], [8], [16], [32], [64], [128], [256]])
Line 84:     def test_multiple_threads(self, count):
I wonder how this will perform for values >= 128 on overcrowded CI slaves
Line 85:         timeout = 5.0
Line 86:         # Wait for count threads + test thread
Line 87:         barrier = concurrent.Barrier(count + 1)
Line 88:         threads = []


-- 
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68525e18f6b3774d7e10af1226a7bc3404c68ae9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list