Change in vdsm[master]: sdm: Add find_domain_manifest helpers

nsoffer at redhat.com nsoffer at redhat.com
Mon Jul 13 21:37:33 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: sdm: Add find_domain_manifest helpers
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/43555/1/vdsm/storage/domainManifestFactory.py
File vdsm/storage/domainManifestFactory.py:

Please use lowercase module names. Also this name is too long. Can we find shorter name like sdc?
Line 1: #
Line 2: # Copyright 2015 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify


-- 
To view, visit https://gerrit.ovirt.org/43555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5d139bde2349c8231141fe842d9ada96fa279fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list