Change in vdsm[master]: Live Merge: Prevent merge when base volume is too small

nsoffer at redhat.com nsoffer at redhat.com
Mon Jul 13 21:20:41 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Live Merge: Prevent merge when base volume is too small
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

Adam, you missed important comment from version 3, I copied it to version 5.

https://gerrit.ovirt.org/#/c/42836/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4711:         # plus a bit more to accommodate additional writes to 'top' during the
Line 4712:         # live merge operation.
Line 4713:         if drive.chunked:
Line 4714:             capacity, alloc, physical = self._getExtendInfo(drive)
Line 4715:             topAllocSize = int(topInfo['apparentsize'])
(copied from version 3)

apparentsize is either the block device size, or the file size. When we extend a drive, we are interesting in the allocation size, which is available only via libvirt.
This change will extend the base volume to the current block device size, instead of the current allocation. This may waste up to 1.5G. Why is this extra size required now?
If you think that the old extend logic was incorrect, please separate this fix to another patch.
Line 4716:             self.extendDriveVolume(drive, baseVolUUID, topAllocSize, capacity)
Line 4717: 
Line 4718:         # Trigger the collection of stats before returning so that callers
Line 4719:         # of getVmStats after this returns will see the new job


-- 
To view, visit https://gerrit.ovirt.org/42836
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf77a7c5108b500c6ec34653ef7570a841def1b4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list