Change in vdsm[ovirt-3.5]: net: tests: clean legacy bonds from kernelConfig

danken at redhat.com danken at redhat.com
Mon Jul 13 13:18:12 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: tests: clean legacy bonds from kernelConfig
......................................................................


Patch Set 1:

(2 comments)

nits about comments

https://gerrit.ovirt.org/#/c/43513/1//COMMIT_MSG
Commit Message:

Line 7: net: tests: clean legacy bonds from kernelConfig
Line 8: 
Line 9: VdsProxy netinfo is built from getVdsCapabilities which reports fake
Line 10: legacy bonds in el6. Remove them from here to avoid lying to
Line 11: KernelConfig
mention that legacy bonds no longer exist on the master branch, hence this patch is not needed there.
Line 12: 
Line 13: Change-Id: I094eb615bbe05e4661b34e8374d105401b8db8b6
Line 14: Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Line 15: Label: ovirt-3.5-only


https://gerrit.ovirt.org/#/c/43513/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 364: 
Line 365:     def _clean_legacy_bonds(self, netinfo):
Line 366:         """VdsProxy netinfo is built from getVdsCapabilities which reports
Line 367:         fake legacy bonds in el6. Remove them from here to avoid lying to
Line 368:         KernelConfig
please state that this assume that bond0-bond4 are NOT being used in any of the tests.

(hey, this patch could even help me on master, when bond0 some times pops up to confuse the test).
Line 369:         """
Line 370:         netinfo = copy.deepcopy(netinfo)
Line 371:         for bond in caps._REQUIRED_BONDINGS:
Line 372:             netinfo.bondings.pop(bond, None)


-- 
To view, visit https://gerrit.ovirt.org/43513
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I094eb615bbe05e4661b34e8374d105401b8db8b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list