Change in vdsm[master]: resize-lun: Rescan fiber channel devices

nsoffer at redhat.com nsoffer at redhat.com
Mon Jul 13 13:13:18 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: resize-lun: Rescan fiber channel devices
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/43388/5/vdsm/storage/fc-scan
File vdsm/storage/fc-scan:

Line 112:                 log.exception("Rescanning %s failed", path)
Line 113: 
Line 114:     def _find_host_devices(self):
Line 115:         host_path = os.path.realpath("/sys/class/fc_host/%s/../.." % self.host)
Line 116:         for device_path in glob.glob("/sys/class/scsi_device/*"):
Lets use glob.iglob()
Line 117:             real_device_path = os.path.realpath(device_path)
Line 118:             if real_device_path.startswith(host_path):
Line 119:                 yield real_device_path
Line 120: 


-- 
To view, visit https://gerrit.ovirt.org/43388
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I201312c44fec30d11ad62823558aa10ad7f7991b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list