Change in vdsm[ovirt-3.5]: net: support strings for 'bridged' in kernelConfig

ybronhei at redhat.com ybronhei at redhat.com
Mon Jul 13 10:24:30 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: net: support strings for 'bridged' in kernelConfig
......................................................................


net: support strings for 'bridged' in kernelConfig

Because kernelConfig did not know how to normalize this parameter in
running config, _should_keep_bridged got wrong parameters if
setupNetworks edited a network with 'bridged': 'false'. This
resulted in a bridge being left behind after the network was removed.

Change-Id: Ib6eb36e69c14c752712ed16d86ed5dd37007f7b7
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1237032
Reviewed-on: https://gerrit.ovirt.org/43446
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netconfpersistence.py
M tests/functional/networkTests.py
2 files changed, 25 insertions(+), 2 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6eb36e69c14c752712ed16d86ed5dd37007f7b7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list