Change in vdsm[ovirt-3.5]: net: restore-nets should support ONBOOT=no

ybronhei at redhat.com ybronhei at redhat.com
Mon Jul 13 10:24:22 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: net: restore-nets should support ONBOOT=no
......................................................................


net: restore-nets should support ONBOOT=no

on 3.5.x devices were persisted with ONBOOT=no. Hence, the selective
restoration would call setupNetworks with only a subset of the
networks and create a partial running config.
To fix this, we fix all ifcfg files to have ONBOOT=yes and verify
all devices are up before computing what has changed since last
call to setSafeNetworkConfig. This will make the following call to
setupNetwork to merely update running config with the 'fixed'
networks, if at all.

Change-Id: I6fa697942e6f26ee833d703437e84144c6de1334
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1203422
Reviewed-on: https://gerrit.ovirt.org/43382
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
M vdsm/vdsm-restore-net-config
2 files changed, 184 insertions(+), 25 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43382
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fa697942e6f26ee833d703437e84144c6de1334
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list