Change in vdsm[ovirt-3.5]: net: flatten ifcfg.ConfigWriter

ybronhei at redhat.com ybronhei at redhat.com
Mon Jul 13 10:24:07 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: net: flatten ifcfg.ConfigWriter
......................................................................


net: flatten ifcfg.ConfigWriter

Make startDevices and stopDevices public for further use.
Also, promotoe them to be module level functions because they do not
need to know about the ConfigWriter state.
Also, sortDeviceIfcfgs is only used with them so make them call it
always. While at it, make them pep8 compatible.

Change-Id: I22676ee45dc7f4be7cd1b74f3f56305cc7e1a97a
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1203422
Reviewed-on: https://gerrit.ovirt.org/43381
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 50 insertions(+), 45 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43381
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22676ee45dc7f4be7cd1b74f3f56305cc7e1a97a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list