Change in vdsm[ovirt-3.5]: no need to call setupNetworks with empty argument during net...

ybronhei at redhat.com ybronhei at redhat.com
Mon Jul 13 10:23:47 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: no need to call setupNetworks with empty argument during network restoration
......................................................................


no need to call setupNetworks with empty argument during network restoration

It is not smart to trust setupNetwork implementation so that it is really a
no-op when called with empty input.

Change-Id: If7de328832c53ef40748c4e932b4340abf1ecf11
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38745
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1203422
Reviewed-on: https://gerrit.ovirt.org/43276
Continuous-Integration: Jenkins CI
---
M vdsm/vdsm-restore-net-config
1 file changed, 9 insertions(+), 7 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43276
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7de328832c53ef40748c4e932b4340abf1ecf11
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list