Change in vdsm[master]: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence

danken at redhat.com danken at redhat.com
Mon Jul 13 09:55:25 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: tests: skip testRestoreToBlockingDHCP if ifcfg persistence
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/43441/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1450:         ifcfg persistence, this is what happens thanks to initscripts,
Line 1451:         regardless of vdsm. Hence, this test is irrelevant there. """
Line 1452:         if vdsm.config.config.get('vars', 'net_persistence') == 'ifcfg':
Line 1453:             raise SkipTest(
Line 1454:                 "with ifcfg persistence, vdsm-restore-net-config is not "
still, the text of the string is misleading.
Line 1455:                 "relevant")
Line 1456: 
Line 1457:         def _get_blocking_dhcp(net_name):
Line 1458:             self.vdsm_net.refreshNetinfo()


-- 
To view, visit https://gerrit.ovirt.org/43441
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I14e875c35a7fb4bcccd497db57d4a70661fe461b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list