Change in vdsm[master]: net: test_setupNetworks_bond_with_custom_option with ifcfg p...

phoracek at redhat.com phoracek at redhat.com
Mon Jul 13 08:09:10 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: net: test_setupNetworks_bond_with_custom_option with ifcfg persistence
......................................................................


Patch Set 1:

Tests is OK with unified persistence, it fails with ifcfg persistence:

======================================================================
ERROR: test_setupNetworks_bond_with_custom_option (functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 206, in wrapper
    func(*args, **kwargs)
  File "/usr/share/vdsm/tests/testValidation.py", line 105, in wrapper
    return f(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 2483, in test_setupNetworks_bond_with_custom_option
    {}, {BONDING_NAME: {'remove': True}}, NOCHK)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 362, in setupNetworks
    self._assert_kernel_config_matches_running_config()
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 371, in _assert_kernel_config_matches_running_config
    normalized_config = kernel_config.normalize(running_config)
  File "/usr/lib/python2.7/site-packages/vdsm/netconfpersistence.py", line 313, in normalize
    self._normalize_bridge(config_copy)
  File "/usr/lib/python2.7/site-packages/vdsm/netconfpersistence.py", line 330, in _normalize_bridge
    for net_attr in config_copy.networks.itervalues():
AttributeError: 'NoneType' object has no attribute 'networks'

But it is not related to the test.

-- 
To view, visit https://gerrit.ovirt.org/43467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I178383e2c0125a1a661108ca9bbb28da74b1a11a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list