Change in vdsm[master]: v2v: enable to use external virtio drivers for virtio

fromani at redhat.com fromani at redhat.com
Mon Jul 13 08:05:49 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: enable to use external virtio drivers for virtio
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

codewise looks OK, but I have a question about the flow. Please see inline comment. -1 for visibility.

https://gerrit.ovirt.org/#/c/42996/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 375: 
Line 376:     def _execution_environments(self):
Line 377:         env = {'LIBGUESTFS_BACKEND': 'direct'}
Line 378:         if 'virtio_iso_path' in self._vminfo:
Line 379:             env['VIRTIO_WIN'] = self._vminfo['virtio_iso_path']
so this came from the outside? How can we trust it?
Line 380:         return env
Line 381: 
Line 382:     def _wait_for_process(self):
Line 383:         if self._proc.returncode is not None:


-- 
To view, visit https://gerrit.ovirt.org/42996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74326b880960c21185cd4ce007852bf0c703d192
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list