Change in vdsm[master]: v2v: handle exception on probing external VMs

fromani at redhat.com fromani at redhat.com
Mon Jul 13 08:03:41 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: handle exception on probing external VMs
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I'm OK with the concept, question inside. -1 for visibility.

https://gerrit.ovirt.org/#/c/43259/1//COMMIT_MSG
Commit Message:

Line 7: v2v: handle exception on probing external VMs
Line 8: 
Line 9: XMLDesc of libvirt domain can throw error,
Line 10: We don't want to fail all the process of fetching external VMs if we
Line 11: fail to read one VM xml.
Can you please elaborate on the nature of these errors?
There is a specific flow or condition that triggers them?

I'm OK in adding a safety net here, but there is probably something strange happening on libvirt layer which should be reported - if there is a BZ already, please link it.
Line 12: 
Line 13: Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02


-- 
To view, visit https://gerrit.ovirt.org/43259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list