Change in vdsm[master]: rwlock: Support non-blocking acquire

alitke at redhat.com alitke at redhat.com
Fri Jul 10 20:29:16 UTC 2015


Adam Litke has posted comments on this change.

Change subject: rwlock: Support non-blocking acquire
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/42928/9/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:

Line 91
Line 92
Line 93
Line 94
Line 95
> Look in line 115 (the diff is confusing).
ahh, indeed.


https://gerrit.ovirt.org/#/c/42928/9/tests/rwlock_test.py
File tests/rwlock_test.py:

Line 200
Line 201
Line 202
Line 203
Line 204
> I don't think here is a bug, but test for True is required.
Agreed: No bug, but a test would be appropriate.


-- 
To view, visit https://gerrit.ovirt.org/42928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec721a07087349050bfe9aa11aacf3be9695fb85
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list