Change in vdsm[master]: vm: event: emit event on guest status change

fromani at redhat.com fromani at redhat.com
Fri Jul 10 09:18:00 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: event: emit event on guest status change
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/43289/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 331:         self._guestSocketFile = self._makeChannelPath(_VMCHANNEL_DEVICE_NAME)
Line 332:         self._qemuguestSocketFile = self._makeChannelPath(_QEMU_GA_DEVICE_NAME)
Line 333:         self.guestAgent = guestagent.GuestAgent(
Line 334:             self._guestSocketFile, self.cif.channelListener, self.log,
Line 335:             self._onGuestStatusChange)
Malicious guest can (try to) DoS VDSM or Engine. The current Vm._evaluatedStatus offers some protection. Do we need to re-introduce it in later patches? see https://gerrit.ovirt.org/#/c/43414
Line 336:         self._domain = DomainDescriptor.from_id(self.id)
Line 337:         self._released = False
Line 338:         self._releaseLock = threading.Lock()
Line 339:         self.saveState()


-- 
To view, visit https://gerrit.ovirt.org/43289
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib98d64a250a6d2de70f7fe5206e5a0ad648c151d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list