Change in vdsm[master]: virt: event: send status event on migrations
fromani at redhat.com
fromani at redhat.com
Fri Jul 10 07:23:58 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: virt: event: send status event on migrations
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/43377/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1572: try:
Line 1573: self._migrationSourceThread.stop()
Line 1574: self._migrationSourceThread.status['status']['message'] = \
Line 1575: 'Migration process cancelled'
Line 1576: self.send_status_event()
> i wonder if it makes any difference. Dst host is ignored, Src host is still
not sure either. Added in the first place for completeness' sake.
Line 1577: return self._migrationSourceThread.status
Line 1578: except libvirt.libvirtError as e:
Line 1579: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID:
Line 1580: return errCode['migCancelErr']
Line 1848: # case VDSM is upgraded from 3.4 to 3.5 on the host without
Line 1849: # rebooting it. Evident on, but not limited to, the HE case.
Line 1850: self._fixLegacyConf()
Line 1851:
Line 1852: self.send_status_event()
> we don't really care when dst vm is created. engine drops that
ok, will add a reminder comment stating that, and possibly drop the event.
Line 1853:
Line 1854: self._devices = self.devMapFromDevSpecMap(dev_spec_map)
Line 1855:
Line 1856: # We should set this event as a last part of drives initialization
--
To view, visit https://gerrit.ovirt.org/43377
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibef280723286987cfaee601eafa20054115ebe36
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list