Change in vdsm[master]: stomp: standalone client

ykaplan at redhat.com ykaplan at redhat.com
Thu Jul 9 15:35:39 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: stomp: standalone client
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/42850/4/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 548:     Returns JsonRpcClient able to receive jsonrpc messages and notifications.
Line 549:     It is required to provide host and port where we want to connect and
Line 550:     request and response queues that we want to use during communication.
Line 551:     We can provide ssl context if we want to secure connection.
Line 552:     """
I think that maybe the best choice instead of this docstring which gives info that is straightforward from the code is to give a warning that when using this you should remember to close the client...
It might save us some uncalled for trouble in the future.
Line 553:     reactor = Reactor()
Line 554:     thread = threading.Thread(target=reactor.process_requests,
Line 555:                               name='Client %s:%s' % (host, port))
Line 556:     thread.setDaemon(True)


-- 
To view, visit https://gerrit.ovirt.org/42850
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8af6272679e115cf8eb80a14227476b59812581c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list