Change in vdsm[master]: vm: event: send status event on powerdown

fromani at redhat.com fromani at redhat.com
Thu Jul 9 13:56:49 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: event: send status event on powerdown
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/43365/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3701:             # Terminate the VM's creation thread.
Line 3702:             self._incomingMigrationFinished.set()
Line 3703:             self.guestAgent.stop()
Line 3704: 
Line 3705:             self.send_status_event()
> I believe this is problematic. The current code mistakenly clears out guest
Will try to move; if fails, will skip.
Line 3706: 
Line 3707:             if self._dom:
Line 3708:                 result = self._destroyVmGraceful()
Line 3709:                 if result['status']['code']:


-- 
To view, visit https://gerrit.ovirt.org/43365
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94261a0115e51a28ab00eed501812583b7871570
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list