Change in vdsm[master]: vm: event: emit event on domDependentInit

fromani at redhat.com fromani at redhat.com
Thu Jul 9 13:53:09 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: event: emit event on domDependentInit
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/43269/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 775:             self.recovering = False
Line 776:             self.saveState()
Line 777: 
Line 778:             self._send_event(
Line 779:                 self._getVmStatus(),
> I wonder...
Sorry, this was lost in rebase fest.
I had the same doubt. I choosed the state we see because of the guest agent delay (see _getVmStauts and _getVmStatusFromGuest).

I was concerned of sending 'Up' too early, and this seemed a bit safer, and helped to keep the patch(set) minimal.

It is open to discussion, of course.
Line 780:                 **self._getRunningVmStats()
Line 781:             )
Line 782: 
Line 783:         except MissingLibvirtDomainError as e:


-- 
To view, visit https://gerrit.ovirt.org/43269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie379911a374a9ba3e82658592c295f7a9a0ac8a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list