Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
nsoffer at redhat.com
nsoffer at redhat.com
Wed Jul 8 14:07:24 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/43211/5/vdsm/storage/protect/spmprotect.sh.in
File vdsm/storage/protect/spmprotect.sh.in:
Line 73: (sleep 20 && echodo $REBOOTCMD) &
Line 74: disown
Line 75: (sleep 7
Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE"
Line 77: echodo $SYSTEMCTL kill --signal=$(kill -t SIGTERM) vdsmd.service
> Also systemctl supports signal names, just like kill:
See https://github.com/systemd/systemd/blob/aab723074c368f65aaf2748d0c530ba9a1e6ad3e/src/basic/signal-util.c#L237-L256
The (evil) line:
DEFINE_PRIVATE_STRING_TABLE_LOOKUP(__signal, int);
Define a fuction for looking up the values in __signal_table[] by the string value, so any of the signals names are available .
Line 78: sleep 2
Line 79: echodo $SYSTEMCTL kill --signal=$(kill -t SIGKILL) vdsmd.service
Line 80: )&
Line 81: disown
--
To view, visit https://gerrit.ovirt.org/43211
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list